Extremely long queue for review

Add-ons Development
#1

Hi AMO team,

I’ve come across add-ons that have been waiting for 6-8 weeks for review.

Do you keep track of such cases? How come add-ons that should be reviewed within 2 weeks get stuck at the queue.

Cheers,
Larry P.

#2

Hi there Larry! Excuse the delay please. With webextensions we have had a lot of google addons copied over, and also new technologies introduced that require special guidelines. What is your addon name? I will get to it within 24h, if I can’t, I’ll update you.

#3

Hi Noitidart,
Thank you for your answer. My add-on name is “Manage Proxy Settings”.
Thank you for your great help!
Cheers,Larry P.

#4

I tested the addon and it wasn’t working well for American proxies, but the GUI is beautiful. The banner is opt in. Approved :slight_smile:

#5

WOW, that was quick!
A question: from now on I’m going to develop WebExtensions API add-ons.

The add-on is going to ask the user (at first use) to accept a new tab default homepage (a blog presenting daily recommendations of Firefox add-ons. It’s an opt-in with default false.

The code for changing new tab URLs was recommended to me by Mr. Soren Hentzschel (developer of https://addons.mozilla.org/en-US/firefox/addon/new-tab-override/?src=search):

const newtabdemo = {
getActiveTab : function () {
return browser.tabs.query({ active : true, currentWindow : true });
},

openNewTabPage : function () {
newtabdemo.getActiveTab().then((tab) => {
browser.tabs.update(tab.id, { url : ‘https://www.google.com’ })
});
}
};

browser.tabs.onCreated.addListener(newtabdemo.openNewTabPage);

My question: will you approve of these tactics?

Thanks for your help,
Larry P.

#6

I don’t think there is any problem with you opt-in policy.

But if you include that code and a user any kind of tab (not only tabs with about:newtab as current URL) the currently active tab (not the tab that was opened) is updated to your URL.

#7

Firefox 54 just added the new tab API, I would recommend you use that.

#8

Thanks Noitidart, do you have a link to this?

#9

You would use this API: https://developer.chrome.com/extensions/override

Here are a bunch of examples: https://www.reddit.com/r/firefox/comments/5qdb8i/got_bored_and_converted_11_chrome_new_tab/

#10

Hi noitidart,
By this page, it doesn’t seem that I can change the URL opened on a new tab automatically to a specific website (such as a blog on Blogspot).
Do I get it wrong?

Thanks for your help,Larry P.

#11

In the example on https://developer.chrome.com/extensions/override you could just include the online blog in an iframe in the myPage.html

#12

Hi,
I implemented API 54 for overwriting the new tab website, as recommended by nikasG.

  1. In the manifest file, I added:
    “chrome_url_overrides”: {
    “newtab”: “myPage.html”
    },
    But - nothing happens. Can you figure out why?
  2. Can I enable/disable the chrome_url_overrides feature from the code (inject.js, event.js) i.e Can I modify manifest.json programmatically?
    Thanks for your help,Larry
#13

Nope. You can’t change the manifest. Unless there are explicit APIs for what you want to do.

#14

Hi AMO team,

I’ve come across add-ons that have been waiting for 6-8 weeks for review. These are WebExtension API add-on.

Do you keep track of such cases? How come add-ons that should be reviewed within 2 weeks get stuck at the queue.

Cheers,
Larry P.

#15

These probably need admin review. Admin reviews have been slower then the the non-admin reviews. To speed it up, you can unminify your code, or do what it takes to get it out of admin review.

#16

Hi noitidart, thanks for your answer. Can I consult you using a private email instead of a public forum?

#17

Yep, please email me at amo-editors@mozilla.org with “Attn: Noit” in the body and I will reply. :slight_smile: